build: add the default search paths for Windows #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building for Windows on Linux, we need to explicitly setup the linker search paths. These are derivable from the UCRT version and the WinSDK base directories which are expected environment variables. This is also how the swift build system finds the directories. Enable this to avoid having the user explicitly setup the `LIB` environment variable for the linker to find the system import libraries.
|
@swift-ci please test |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: add the default search paths for Windows Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building for Windows on Linux, we need to explicitly setup the
linker search paths. These are derivable from the UCRT version and the
WinSDK base directories which are expected environment variables. This
is also how the swift build system finds the directories. Enable this
to avoid having the user explicitly setup the
LIBenvironment variablefor the linker to find the system import libraries.