BlocksRuntime: adjust implementation for Windows x64 #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjust the BlocksRuntime to work on Windows x64 which is an LLP64 environment. This primarily comes down to using `size_t` for the size parameter for the allocation routines. A secondary change which is needed is the type cast for the `InterlockedCompareExchange` operation on Windows. A small cleanup is included which removes the definition of an unused function.
|
@swift-ci please test |
|
A similar change is in apple/swift-corelibs-foundation for this, but, since both are used, we should still get this merged. |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
BlocksRuntime: adjust implementation for Windows x64 Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjust the BlocksRuntime to work on Windows x64 which is an LLP64
environment. This primarily comes down to using
size_tfor the sizeparameter for the allocation routines. A secondary change which is
needed is the type cast for the
InterlockedCompareExchangeoperationon Windows. A small cleanup is included which removes the definition of
an unused function.