build: fix symlink creation #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adjusts the symlink creation so that it always occurs. This also allows us to ensure that we wire up the dependency for the swift module to the symlink creation. The CMake based build would fail without this when trying to build dispatch for SourceKit on Linux.
|
CC: @das |
|
CC @dgrove-oss so, the swift side of the change is ready to go after this change. We are two commits away from all of the non-Darwin targets being ready to switch over to the CMake build! |
|
Friendly ping @das (for a work day). This is the last patch holding up the switch over to CMake for the integration with swift. |
|
@das is on vacation ;) |
|
@MadCoder oh, haha! Thanks for the assist! |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: fix symlink creation Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the symlink creation so that it always occurs. This also
allows us to ensure that we wire up the dependency for the swift module
to the symlink creation. The CMake based build would fail without this
when trying to build dispatch for SourceKit on Linux.