Skip to content

Fix building on armv6 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2017
Merged

Fix building on armv6 #296

merged 2 commits into from
Aug 27, 2017

Conversation

zwaldowski
Copy link
Contributor

Applies same change from #155.

@zwaldowski zwaldowski changed the title [master] Fix building on armv6 Fix building on armv6 Aug 27, 2017
@MadCoder
Copy link
Contributor

@swift-ci please test

@MadCoder MadCoder self-assigned this Aug 27, 2017
@MadCoder
Copy link
Contributor

you may want to check if it builds with cmake too as I understand cmake is the future and autoconf is on life support.

@zwaldowski
Copy link
Contributor Author

My (admittedly rather thin) understanding of CMake is that neither problem exists there. When built within the Swift tree, it'll either pass or inherit the correct arch-canonicalized install paths into Dispatch's cmake step like it does to produce other overlays.

@MadCoder MadCoder merged commit 0e35ed9 into swiftlang:master Aug 27, 2017
ktopley-apple pushed a commit that referenced this pull request Dec 6, 2018
Fix building on armv6

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants