Fix compilation warnings in extended test suite #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vast majority are related to resolving size_t vs. long. I selectively added test_sizet_ functions to bsdtests.h as the most contained way to resolve these. (I think test_sizet_COMPAREOP reads better than test_size_t_COMPAREOP, but if you disagree it can be changed easily). |
das
requested changes
Aug 1, 2017
tests/dispatch_priority.c
Outdated
| n_blocks(void) | ||
| { | ||
| static dispatch_once_t pred; | ||
| static int n; | ||
| dispatch_once(&pred, ^{ | ||
| #ifdef __linux__ | ||
| n = sysconf(_SC_NPROCESSORS_CONF); | ||
| n = (int)sysconf(_SC_NPROCESSORS_CONF); |
| @@ -189,6 +189,20 @@ test_long_format(long actual, long expected, const char* format, ...) | |||
| } | |||
|
|
|||
| void | |||
| _test_sizet(const char* file, long line, const char* desc, size_t actual, size_t expected) | |||
There was a problem hiding this comment.
reads odd but I agree test_size_t is not much better, I don't feel strongly either way
tests/dispatch_io.c
Outdated
| total_size += size; | ||
| files_opened++; | ||
| test_async_read(node->fts_path, size, option, queue, ^(size_t len){ | ||
| OSAtomicAdd32(len, bytes); | ||
| OSAtomicAdd32((int32_t)len, (volatile int32_t *)bytes); |
There was a problem hiding this comment.
bad indent
we should probably convert the testsuite to stdatomic.h at some point...
tests/dispatch_read2.c
Outdated
| @@ -71,7 +71,7 @@ dispatch_read2(dispatch_fd_t fd, | |||
| test_stop(); | |||
| } | |||
| dispatch_source_t reader = dispatch_source_create(DISPATCH_SOURCE_TYPE_READ, | |||
| fd, 0, queue); | |||
| (uintptr_t)fd, 0, queue); | |||
Fixes to build the extended test suite (not built/run under Swift CI) when using the expanded set of compiler warning flags.
dgrove-oss
force-pushed
the
fix-warnings-extended-tests
branch
from
1ca6fa6 to
820d638
Compare
|
fixed the bad indentation. |
das
approved these changes
Aug 2, 2017
|
thanks! |
atrick
added a commit
to atrick/swift-corelibs-libdispatch
that referenced
this pull request
Aug 2, 2017
This restores pull request swiftlang#290 from dgrove-oss/fix-warnings-extended-tests. This was an accidental revert. Somehow the revert button on github led me to the wrong PR.
|
I accidentally reverted this and reapplied it here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to build the extended test suite
(not built/run under Swift CI) when using
the expanded set of compiler warning flags.