build: add support to build with sanitization #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @das @dgrove-oss |
|
Since I put this up on a weekend, a gentle ping during the work week! |
|
out of interest, do the sanitizers actually work with libdispatch on Linux ? on Darwin, they depend on layers of the OS layered above libdispatch (or entangled with it) so we cannot use them for libdispatch at present probably means you want to conditionalize this for linux |
|
Yeah, I was able to build with them on Linux. I can certainly add a limitation to only allow them on Linux. |
|
but do they run? (the problem on Darwin is not at build time FWIW) |
Add support to configure the build to use sanitizers to aid in finding issues. The `DISPATCH_USE_SANIZITERS` is a cmake option that defaults to none, but can be one of `Address, Memory, MemoryWithOrigins, Undefined, Leaks, Address;Undefined`. This allows for easily building libdispatch and the tests with the sanitizers.
|
Yes, it did run as well for me :-). Helped find that div-by-zero bug in the test! |
|
awesome! |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
build: add support to build with sanitization Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to configure the build to use sanitizers to aid in finding
issues. The
DISPATCH_USE_SANIZITERSis a cmake option that defaultsto none, but can be one of
Address,Memory,MemoryWithOrigins,Undefined,Leaks,Address;Undefined. This allows for easily buildinglibdispatch and the tests with the sanitizers.