CMake: carry over some nuances from autotools test config #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Jul 27, 2017
tests/CMakeLists.txt
Outdated
|
|
||
| # test-specific compiler flags (for currently disabled tests) | ||
| #add_unit_test(dispatch_priority2 SOURCES dispatch_priority.c) | ||
| #target_compile_options(dispatch_priority2, PRIVATE -DUSE_SET_TARGET_QUEUE=1) |
There was a problem hiding this comment.
Drop the ,. Why is this test disabled? We do have the DISABLED_TEST keyword, so we can add the test but not have it be built/run.
add_unit_test(dispatch_priority2
DISABLED_TEST
SOURCES
dispatch_priority.c)
I think that we should add a dummy target so we can actually add the additional flags.
Port more capabilities from Makefile.am: 1. test-specific compilation flags 2. support for lenient deadlines when running in the Swift CI 3. extended test suite (tests we disable because they occasionally fail) 4. list of not ported tests (Darwin-only functionality)
dgrove-oss
force-pushed
the
cmake-test-parity-with-autoconf
branch
from
0010d9a to
0ee4a14
Compare
|
updated and expanded (noticed some additional useful bits that hadn't been ported over). |
compnerd
approved these changes
Jul 28, 2017
|
lgtm, thanks! |
ktopley-apple
pushed a commit
that referenced
this pull request
Dec 6, 2018
CMake: carry over some nuances from autotools test config Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port over test-specific compilation flags and support for
lenient deadlines for running in the Swift CI from Makefile.am