cmake parity updates #260
cmake parity updates #260
Conversation
Use the target_sources function to add additional sources to the dispatch target rather than managing lists. This simplifies the handling and modernises the CMake usage.
Add support to the cmake based build system to use the internal pthread workqueue implementation. This restores parity with the autotools build.
|
very cool, thanks! BTW, I've made some progress on getting the CMake build to work on Darwin (against submodules of the dependent projects under github.com/apple/darwin*), I'll have to rebase on top of this and see if that solves some of the problems I was running into |
|
@das awesome! Really looking forward to seeing this become the one build system for libdispatch. I am able to build with this change on linux and all tests pass. If you have specific things that I can try to address in the build system, to help in getting everything switched over, let me know! |
| swift/Wrapper.swift | ||
| CFLAGS | ||
| -fblocks | ||
| -fmodule-map-file=${CMAKE_SOURCE_DIR}/dispatch/module.modulemap |
There was a problem hiding this comment.
this is a pre-existing bug but this is the linux modulemap, if we ever want this part to work on Darwin this path will need to be conditionalized per platform
cmake parity updates Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
This updates the CMake build to bring it to parity with the autotools build. It also cleans up some of the custom list management for more modern approaches.