clarify config of pthread_workqueue vs. internal_workqueue #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in review of PR-206, DISPATCH_USE_INTERNAL_WORKQUEUES should not enable HAVE_PTHREAD_WORKQUEUES. Instead, a new DISPATCH_USE_WORKQUEUES is defined in queue.c to guard code that should be enabled in either case.
MadCoder
approved these changes
May 19, 2017
|
@MadCoder, I guess this needs to be tested by Swift CI and then it can be merged? |
|
Yes. I'm not suer why I forgot to fire it @swift-ci please test |
das
added a commit
that referenced
this pull request
Jul 31, 2017
clarify config of pthread_workqueue vs. internal_workqueue Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in review of PR-206, DISPATCH_USE_INTERNAL_WORKQUEUES
should not enable HAVE_PTHREAD_WORKQUEUES. Instead, a new
DISPATCH_USE_WORKQUEUES is defined in queue.c to guard code that
should be enabled in either case.