Fix building on RasPi #240
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shims.h includes shims/lock.h which calls DISPATCH_INTERNAL_CRASH. However this is defined below the include of shims.h in internal.h and hence fails the build. This commit moves the includes of the dependent files below the define of DISPATCH_INTERNAL_CRASH.
|
Closing this in favor of #233 which is about the same issue but has a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shims.hincludesshims/lock.hwhich callsDISPATCH_INTERNAL_CRASH. However this is defined below the include ofshims.hininternal.hand hence fails the build on the RasPi.Moving the includes below the define of
DISPATCH_INTERNAL_CRASHfixes the issue.I don't know why this works on regular x86/x64 builds, though.