Fix compile error on s390x in shims/lock.h #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCoder
reviewed
Apr 3, 2017
|
Yes it's comparable to Intel (see Table 5 in http://www.rdrop.com/~paulmck/scalability/paper/whymb.2009.04.05a.pdf). |
MadCoder
suggested changes
Apr 3, 2017
src/shims/lock.h
Outdated
| // On Intel, any load is a load-acquire, so we don't need to be fancy | ||
| // s390x has a strong memory model |
There was a problem hiding this comment.
I'd comment "same for s390x"
Do we want to throw in s390 too here? Or is that too obsolete as an architecture?
There was a problem hiding this comment.
ya I think we only have s390x in Swift so I'd like to stick with that. Thanks for the review!
… model and does not require membarrier.
vivkong
force-pushed
the
fix_compiler_error_swift31
branch
from
eef18e6 to
86d036d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s390x has a strong memory model and does not require membarrier.
This is the same as #234 but for the 3.1 branch