remove unused dependency on linux/membarrier.h for intel to fix CI build #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadCoder
suggested changes
Feb 22, 2017
src/shims/lock.h
Outdated
| @@ -89,7 +89,9 @@ _dispatch_lock_has_failed_trylock(dispatch_lock lock_value) | |||
|
|
|||
| #elif defined(__linux__) | |||
| #include <linux/futex.h> | |||
| #if !defined(__x86_64) && !defined(__i386__) | |||
There was a problem hiding this comment.
I think it should be __x86_64__ not __x86_64
add dependency on linux-libc-dev to INSTALL.md for other architectures
das
force-pushed
the
das-disable-linux-membarrier-include
branch
from
c6d5ab6 to
dea8577
Compare
MadCoder
approved these changes
Feb 22, 2017
das
added a commit
that referenced
this pull request
May 25, 2017
remove unused dependency on linux/membarrier.h for intel to fix CI build Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dependency on linux-libc-dev to INSTALL.md for other architectures