Remove ObjC support functions not needed on non-ObjC platforms #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
Remove ObjC support functions not needed on non-ObjC platforms Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on non-Apple platforms, this removes ObjC support functions that are not needed which allows removal of
libdl.Hopefully I have used the correct flags,
HAVE_OBJCin the code andUSE_OBJCin the makefile but if there are better flags to use please let me know.I tested this by building the static library
libdispatch.aand linking it into a statically built swift program which includedimport Dispatchand didnt see any missing references so the functions that have been excluded should be correct.