fix libdispatch.a to include Swift overlay symbols #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
changed the title
dgrove-oss
reviewed
Feb 6, 2017
src/Makefile.am
Outdated
| # the PIC and non-PIC case. | ||
| $(abs_builddir)/swift/swift_overlay.lo: $(abs_builddir)/swift/swift_overlay.o | ||
| mv $(abs_builddir)/swift/swift_overlay.o $(abs_builddir)/swift/.libs/swift_overlay.o.save | ||
| $(LIBTOOL) --mode=compile --tag=CC true -o $< -c foo.c |
There was a problem hiding this comment.
I'd suggest using /dev/null instead of foo.c to make it clearer that your compilation command ('true') doesn't actually care about the input file you are giving it.
There was a problem hiding this comment.
👍 thanks, will fix right now
The static version (`libdispatch.a`) that can be compiled using
`./configure --enable static=yes` was missing all the Swift overlay symbols
(everything in `swift_overlay.o`). The reason for that is that the linker is
invoked through libtool which wants `.lo` files but the Swift overlay got passed
as a `.o` file. This first of all leads to this warning:
*** Warning: Linking the shared library libdispatch.la against the non-libtool
*** objects [...]/swift_overlay.o is not portable!
And the result is that libtool doesn't include `swift_overlay.o` when putting
together the static library `libdispatch.a`.
This patch fixes this problem is a pretty crude way. The real problem is that
libtool doesn't understand Swift. So it can't be used when compiling
`swift_overlay.o`. In order to still get a `.lo` file this patch tricks libtool
into generating one from the `swift_overlay.o` generated by `swiftc`. It's very
hacky but I'm not sure what else to do.
weissi
force-pushed
the
jw-fix-libdispatch.a
branch
from
5b46774 to
eaa77e9
Compare
|
looks plausible to me; it's a hack, but it is better than what we were doing. @MadCoder any thoughts? |
|
@swift-ci please test |
|
this is so gross. but I guess we need to be unblocked until we get a better build system |
das
pushed a commit
that referenced
this pull request
May 25, 2017
fix libdispatch.a to include Swift overlay symbols Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static version (
libdispatch.a) that can be compiled using./configure --enable static=yeswas missing all the Swift overlay symbols(everything in
swift_overlay.o). The reason for that is that the linker isinvoked through libtool which wants
.lofiles but the Swift overlay got passedas a
.ofile. This first of all leads to this warning:And the result is that libtool doesn't include
swift_overlay.owhen puttingtogether the static library
libdispatch.a.This patch fixes this problem is a pretty crude way. The real problem is that
libtool doesn't understand Swift. So it can't be used when compiling
swift_overlay.o. In order to still get a.lofile this patch tricks libtoolinto generating one from the
swift_overlay.ogenerated byswiftc. It's veryhacky but I'm not sure what else to do.