SR-3771 and SR-3751: libdispatch should not depend on external libkqueue #207
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert back to libkqueue version that has the fix for SR-2941 but does not have the changes to remove the autotools-based build system.
|
@swift-ci Please test |
dgrove-oss
changed the title
dgrove-oss
changed the title
|
@MadCoder would you mind merging this to master? I screwed up in #203 and moved libkqueue too far forward. I didn't notice (and neither did the CI testing) that because the latest libkqueue removed the autotools based build system it meant that we stopped building libkqueue from source when building libdispatch. On both my machine and the Swift CI machines, libkqueue is installed, so the build just defaults back to using the system libkqueue which is not what we want. Thanks & sorry for the churn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back to libkqueue version that has the fix for
SR-2941 but does not have the changes to remove the
autotools-based build system.