Skip to content

Fixes incorrect behavior of DispatchData.copyBytes() when the start … #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Fixes incorrect behavior of DispatchData.copyBytes() when the start … #204

merged 1 commit into from
Jan 30, 2017

Conversation

ktopley-apple
Copy link
Contributor

@ktopley-apple ktopley-apple commented Jan 25, 2017

Fixes incorrect result of calling the DispatchData.copyBytes() method when the start index of the source range is not 0. Also fixes the behavior when the start index does not coincide with the start of a region.

Related to #7036.

rdar://problem/29005050

@ktopley-apple
Copy link
Contributor Author

@swift-ci Please test

@ktopley-apple ktopley-apple requested a review from moiseev January 25, 2017 22:33
@ktopley-apple ktopley-apple changed the title Fixes inccorrect behavior of DispatchData.copyBytes() when the start … Fixes incorrect behavior of DispatchData.copyBytes() when the start … Jan 25, 2017
Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments about the usage of startIndex vs lowerBound apply. But other than that, looks good.

…index is not 0 and adds a test for that method.

 Please enter the commit message for your changes. Lines starting
@ktopley-apple
Copy link
Contributor Author

Updated with review comments.

@moiseev
Copy link
Contributor

moiseev commented Jan 26, 2017

LGTM

@ktopley-apple
Copy link
Contributor Author

@swift-ci Please test

1 similar comment
@shahmishal
Copy link
Member

@swift-ci Please test

@ktopley-apple ktopley-apple merged commit e199473 into swiftlang:master Jan 30, 2017
das pushed a commit that referenced this pull request Feb 21, 2017
Fixes incorrect behavior of DispatchData.copyBytes() when the start …

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants