Skip to content

Correct signedness handling of DispatchTimeInterval #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2016

Conversation

dgrove-oss
Copy link
Contributor

Replicate e32016ffd765020c696bc5d1e42606074305f2db
from the Darwin overlay to the wrapping overlay.

Replicate e32016ffd765020c696bc5d1e42606074305f2db
from the Darwin overlay to the wrapping overlay.
@dgrove-oss
Copy link
Contributor Author

Do we need a swift 3 branch version of this patch as well?

@mwwa
Copy link
Contributor

mwwa commented Sep 12, 2016

This looks good, there's no need to port to the swift repo as the changes are already there. Is that what you meant? (Or do you mean a swift 3 branch of libdispatch?)

@mwwa
Copy link
Contributor

mwwa commented Sep 12, 2016

@swift-ci please test

@dgrove-oss
Copy link
Contributor Author

I meant the swift3 branch of libdispatch. I think this is an internal implementation change that doesn't impact the exposed API, so we don't need it in swift3-branch, but I wanted to confirm that with you.

@mwwa
Copy link
Contributor

mwwa commented Sep 12, 2016

Gotcha, yeah that's what I thought too.

@dgrove-oss
Copy link
Contributor Author

The PR test failed with an assertion in libkqueue when running a Foundation test case. I've built and run locally half a dozen times and can't reproduce. It's possible I'm missing something, but it might have been a glitch on the test machine. I did notice at the end of the log that Jenkins complained:

[xUnit] [ERROR] - Clock on this slave is out of sync with the master, and therefore 
I can't figure out what test results are new and what are old.

@mwwa
Copy link
Contributor

mwwa commented Sep 13, 2016

Ok, I'll go ahead and merge.

@mwwa mwwa merged commit 8803d07 into swiftlang:master Sep 13, 2016
@dgrove-oss dgrove-oss deleted the libdispatch-time-signedness branch September 15, 2016 12:36
das pushed a commit that referenced this pull request Feb 21, 2017
Correct signedness handling of DispatchTimeInterval

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants