fixes for swiftc compiler warnings #141
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dgrove-oss
commented
Aug 10, 2016
dgrove-oss
commented
- @NoEscape is now the default for blocks (and is deprecated)
- unreachable default in switch statement
1. @NoEscape is now the default for blocks (and is deprecated) 2. unreachable default in switch statement
dgrove-oss
force-pushed
the
fix-swiftc-warnings
branch
2 times, most recently
from
1d9788e to
b79bbb5
Compare
|
rebased to latest master to resolve conflicts. |
|
@mwwa to review and see if we need to do similar changes in swiftc |
|
FYI this was addressed by swiftlang/swift@b7c9edd for the swift-side changes. |
|
@swift-ci please test |
|
Part of this is superseded by #154 |
|
obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.