Add libkqueue as a git submodule #109
Conversation
| AC_CHECK_HEADER(sys/event.h, [], | ||
| [AC_SEARCH_LIBS([kqueue], [kqueue], [], | ||
| [AC_MSG_ERROR([unable to find kqueue() function])] | ||
| )] |
There was a problem hiding this comment.
Why the change from PKG_CHECKS_MODULES to AC_SEARCH_LIBS? PKG_CHECK_MODULES will define KQUEUE_CFLAGS and KQUEUE_LIBS so you don't have to hardwire them in the makefile
There was a problem hiding this comment.
@seabaylea is porting my changes, here. I'm trying to remember why I changed this. I think I couldn't get M4 to parse the PKG_CHECKS_MODULES correctly when under an AS_IF - and switched to AC_SEARCH_LIBS instead.
There was a problem hiding this comment.
Not sure if it is accurate, but I did find this page describing how to use the two together: https://autotools.io/pkgconfig/pkg_check_modules.html
seabaylea
force-pushed
the
kqueue
branch
2 times, most recently
from
08cb4c6 to
ab7d37a
Compare
|
I've switched over/back to using |
|
sorry you lost that race and conflict, please update. |
|
@MadCoder Updated to resolve merge conflict. |
Add libkqueue as a git submodule Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
We added libkqueue as a git submodule to
experimental/foundationunder PR #76 to pick up a fix that resolves a crash when utilising Dispatch in NSURLSession.We still have the same issue in the NSURLSession test, so we need to add the git submodule to
masteras well.