[SR-2922] libdispatch depdencies are stale, "module file was created by an older version of the compiler"

[swift-ci]

Previous ID	SR-2922
Radar	rdar://28725613
Original Reporter	erg (JIRA User)
Type	Bug
Status	Resolved
Resolution	Done

Additional Detail from JIRA

Votes	0
Component/s	libdispatch
Labels	Bug, Linux
Assignee	dgrove-oss (JIRA)
Priority	Medium

md5: d026254f314b5f173b0566d37814f460

Issue Description:

The Swift public CI bots are seeing a problem with incremental builds in libdispatch; Block.o.~partial.swiftmodule is complaining about Dispatch being stale.

We are calling reconfigure but it's not enough, apparently:

libdispatch: using gold linker
Reconfiguring libdispatch
+ mkdir -p /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64
+ pushd /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift-corelibs-libdispatch
~/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift-corelibs-libdispatch ~/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test
+ autoreconf -fvi
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext

:0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Block.o.~partial.swiftmodule

Compile command:
./swift/utils/build-script --assertions --release --test --validation-test --lit-args=-v --build-subdir=buildbot_incremental --llbuild --swiftpm --xctest --foundation --libdispatch --test=0 --validation-test=0 --long-test=1 --test-optimized=0 – --reconfigure

Sample failure log, will eventually rotate away:

https://ci.swift.org/view/swift-3.0-branch/job/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/415/consoleFull#-964214433ee1a197b-acac-4b17-83cf-a53b95139a76

Failure log:

Making all in src
make[1]: Entering directory /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src' make all-am make[2]: Entering directory /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src'
/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/swift-linux-x86_64/bin/swiftc -frontend -emit-module /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Block.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Data.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Dispatch.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/IO.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Private.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Queue.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Source.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Time.o.~partial.swiftmodule /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Wrapper.o.~partial.swiftmodule
-Xcc -fmodule-map-file=/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift-corelibs-libdispatch/dispatch/module.modulemap -I/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift-corelibs-libdispatch -Xcc -fblocks -O -module-cache-path .. -module-link-name dispatch
-o /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Dispatch.swiftmodule -emit-module-doc-path /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Dispatch.swiftdoc
:0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Block.o.~partial.swiftmodule
make[2]: *** [/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Dispatch.swiftmodule] Error 1
make[2]: Leaving directory /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src' make[1]: \*\*\* [all] Error 2 make[1]: Leaving directory /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src'
make: *** [all-recursive] Error 1
/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 2, aborting
/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 1, aborting
Build step 'Execute shell' marked build as failure
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - 1 test report file(s) were found with the pattern 'buildbot_incremental/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/lit-tests.xml' relative to '/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test' for the testing framework 'JUnit'.
[xUnit] [INFO] - Converting '/home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/swift-linux-x86_64/swift-test-results/x86_64-unknown-linux-gnu/lit-tests.xml' .
[xUnit] [INFO] - Check 'Failed Tests' threshold.
[xUnit] [INFO] - Check 'Skipped Tests' threshold.
[xUnit] [INFO] - Setting the build status to FAILURE
[xUnit] [INFO] - Stopping recording.
[BFA] Scanning build for known causes...
[BFA] Found failure cause(s):
[BFA] Compile Error from category Compile
[BFA] Done. 0s
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Last: 414 FAILURE
Current: 415 FAILURE
Current Issue: :0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Block.o.~partial.swiftmodule
Last Issue: :0: error: module file was created by an older version of the compiler; rebuild 'Dispatch' and try again: /home/buildnode/jenkins/workspace/oss-swift-3.0-incremental-RA-linux-ubuntu-14_04-long-test/buildbot_incremental/libdispatch-linux-x86_64/src/swift/Block.o.~partial.swiftmodule
Email sending was cancelled by user script.
Finished: FAILURE

[swift-ci]

Comment by David Grove (JIRA)

In the master branch, we merged #178 as an attempt to fix this problem. It adds a dependency on the swiftc executable to the %.o: %.swift rules so that the .swiftmodule files are recognized as being out-of-date when swiftc changes.

We didn't do a corresponding change to the 3.0 branch. I can put together a PR to the swift-3.0 branch this morning.

[swift-ci]

Comment by David Grove (JIRA)

#184

[swift-ci]

Comment by David Grove (JIRA)

PR merged