Disable tests that use the internet #945
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
I've also filed rdar://31568133 for the more general fix of getting the DTDs back into an unsecured domain. |
Plist DTDs were recently moved from http://www.apple.com/DTDs/PropertyList-1.0.dtd to https://www.apple.com/DTDs/PropertyList-1.0.dtd (note the https). libXML, however, is not setup to request DTDs from secure domains and fails. This causes a spurious failure in the validation test checking for failure and a real failure in the validation test checking for success. In either case, these tests introduce a hard dependency on the internet into the test suite. I’ve disabled them for now and filed rdar://31567922 about this.
|
@swift-ci test |
|
⛵️ |
|
Yay, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plist DTDs were recently moved from
http://www.apple.com/DTDs/PropertyList-1.0.dtd to
https://www.apple.com/DTDs/PropertyList-1.0.dtd (note the https).
libXML, however, is not setup to request DTDs from secure domains and
fails. This causes a spurious failure in the validation test checking
for failure and a real failure in the validation test checking for
success. In either case, these tests introduce a hard dependency on
the internet into the test suite. I’ve disabled them for now and filed
rdar://31567922 about this.