Reapply endianess fix in CFInternal.h that got overwrote by import fr… #934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
Apr 7, 2017
| @@ -341,18 +341,24 @@ CF_EXPORT void * __CFConstantStringClassReferencePtr; | |||
|
|
|||
| CF_EXPORT void *__CFConstantStringClassReference[]; | |||
|
|
|||
| #if __CF_BIG_ENDIAN__ | |||
| #define CFINFO {0x00, 0x00, 0x07, 0xc8} | |||
There was a problem hiding this comment.
Can we actually give this a better name, like CF_CONST_STRING_INFO?
There was a problem hiding this comment.
Sure. I've changed the name.
|
@parkera, can you please merge this PR too for swift_3.1_branch? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om Sierra
The import from Sierra back in December overwrote a fix in CFInternal.h (#386) which is breaking s390x.
I'll create another PR for master.