Update HTTPCookiePropertyKey.path comment #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code comments that are the subject here don't seem to be consumed in any online documentation , neither in HTTPCookie.init(properties:) nor HTTPCookiePropertyKey. I wonder if we need those HTML tags anymore. May be we should do away with them too? |
|
I'll merge this since it addresses the SR. But we should revisit the code comments in question to check if we could do more of a cleanup. Thanks! @swift-ci test and merge |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is relating to SR-3821
The comment seems to suggest that supplying a value for
pathis optional and if a value isn't provided it'll either infer fromHTTPCookiePropertyKey.originURLor use a default of "/". None of those seem to be the case though, andHTTPCookie([...])will returnnilif you haven't provided a value forpath.Tracked down some documentation to support this as well.