Account for kCFBooleanTrue and kCFBooleanFalse being present in bridged payloads #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@parkera if you wouldn't mind taking a look at this |
…ed payloads This converts kCFBooleanTrue and kCFBooleanFalse into true and false and adds subclassing callout hooks for CFNumber to invoke swift routines.
|
@swift-ci please test |
|
Looks good to me. Maybe get a few more test cases for the various kinds of results for the CFNumber type? |
|
(we may be able to do that in a future commit since this has a test case for the bug at hand) |
|
@swift-ci Please test and merge |
|
@swift-ci please test and merge |
|
3 times is the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts kCFBooleanTrue and kCFBooleanFalse into true and false and adds subclassing callout hooks for CFNumber to invoke swift routines.
Additionally it corrects the class callouts for cluster types when archiving plist types such that it invokes the class for coder instead of relying on the distinct type of the object being passed.