Implementing NSFileManager.homeDirectoryForCurrentUser and homeDirect… #860
Conversation
…ory(forUser userName: )
| @@ -712,9 +712,15 @@ extension FileManager { | |||
| } | |||
|
|
|||
| extension FileManager { | |||
| open var homeDirectoryForCurrentUser: URL { NSUnimplemented() } | |||
| open var homeDirectoryForCurrentUser: URL { | |||
| return homeDirectory(forUser: CFCopyUserName().takeRetainedValue()._swiftObject)! | |||
There was a problem hiding this comment.
Hm, is a force unwrap the right answer here if we can't find a home directory? Maybe a fallback instead?
There was a problem hiding this comment.
I wonder if the var declaration could be changed to open var homeDirectoryForCurrentUser: URL?. It would make sense for it to be nil if it couldn't be obtained by homeDirectory(forUser:)
There was a problem hiding this comment.
Looking at CF, it seems the only way for this to totally fail is if even $HOME is unset. Perhaps that's an environment error and asserting is the right answer in that case.
There was a problem hiding this comment.
@parkera When you say asserting is the right answer do you mean we abort the application like this
let currentUser = CFCopyUserName().takeRetainedValue()._swiftObject
guard !currentUser.isEmpty else { fatalError ("$HOME not set") }
return homeDirectory(forUser: currentUser)!
I agree with @OscarSwanros . I cannot return nil as the declaration says that I cannot return nil.
There was a problem hiding this comment.
I'm saying it's ok as written.
|
@swift-ci please test |
…ory(forUser userName: )