Skip to content

[LengthFormatter] Implementation of LengthFormatter and tests #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2016
Merged

[LengthFormatter] Implementation of LengthFormatter and tests #745

merged 2 commits into from
Dec 20, 2016

Conversation

kweinmeister
Copy link

  • Implementation of all unimplemented functions in NSLengthFormatter.swift
  • Test cases covering all functions, including paths for US, metric system, and isForPersonHeightUse
  • Includes workaround for issue in which Locale attributes are not populated

@kweinmeister kweinmeister changed the title Implementation of LengthFormatter and tests [LengthFormatter] Implementation of LengthFormatter and tests Dec 14, 2016
@parkera
Copy link
Contributor

parkera commented Dec 16, 2016

Cool!

@parkera
Copy link
Contributor

parkera commented Dec 16, 2016

cc @lifeissweetgood

@parkera
Copy link
Contributor

parkera commented Dec 16, 2016

@swift-ci please test

@lifeissweetgood
Copy link

This is a good start! Eventually it would be great to add support for different formats (rather than hardcoding "\(formattedValue)\(separator)\(unitString(fromValue: value, unit: unit))"). Til then though, lgtm!

@parkera
Copy link
Contributor

parkera commented Dec 19, 2016

@kweinmeister would you mind resolving the merge conflicts so we can get this in?

Merge branch 'master' of https://github.com/kweinmeister/swift-coreli…
dfd1d74 
…bs-foundation into LengthFormatter

# Conflicts:
#	Foundation.xcodeproj/project.pbxproj
@kweinmeister
Copy link
Author

@lifeissweetgood @parkera Done!

@parkera
Copy link
Contributor

parkera commented Dec 20, 2016

@swift-ci test and merge

@swift-ci swift-ci merged commit 587557d into swiftlang:master Dec 20, 2016
@kweinmeister kweinmeister deleted the LengthFormatter branch January 10, 2017 17:10
@naithar naithar mentioned this pull request Jan 20, 2017
Merged
@swift-ci swift-ci mentioned this pull request Dec 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifeissweetgood lifeissweetgood lifeissweetgood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kweinmeister @parkera @lifeissweetgood @swift-ci