Fixes for calendar initialization #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in NSCalendar. Fixes a crash caused by trying to deallocate a CFCalendar that hadn't been fully initialized. Re-enables support for the Chinese calendar. Adds tests for initializaing NSCalendar and fetching basic date info.
parkera
added a commit
that referenced
this pull request
Dec 8, 2015
Fixes for calendar initialization
|
Thanks! |
|
Not sure if it is just me but the following tests are failing:
XCTAssertEqual(components.day, 5)
XCTAssertEqual(components.day, 7)
XCTAssertEqual(components.day, 15)Not sure if it is related to timezone or not but my timezone is JST (GMT+9). |
|
@thii can you open a bug for us at bugs.swift.org? |
|
I opened one here https://bugs.swift.org/browse/SR-171. |
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
Add CodeActions/Command structure
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Make sure swiftlang/swift#34023, which removes /usr/lib/swift/linux from the RUNPATH of several Swift libraries, stays that way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is copied from #44, which got closed when I reorganized the branches and split up the request into two parts.
This request is to fix a few related bugs in initializing calendars and getting date information out of them: