[SR-3329] URLQueryItems are not getting encoded in to the URL

[saiHemak]

No description provided.

[saiHemak]

To work-around SR-2462 compiler bug.

[pushkarnk]

I'm just kicking off a test. Thanks.

@swift-ci please test

[saiHemak]

The build passed successfully in the local environment .Looking in to the build failure

[parkera]

Test Case 'TestNSURLComponents.test_createURLWithComponents' started at 08:21:47.819
/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift/utils/build-script-impl: line 252:  8657 Segmentation fault      "$@"
/home/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-Linux/swift/utils/build-script: fatal error: command terminated with a non-zero exit status 139, aborting
Build step 'Execute shell' marked build as failure

[pushkarnk]

We see a similar failure in #713 It again happens in the new test case

[parkera]

@swift-ci please test

[pushkarnk]

A known libkqueue test failure. Triggering the tests again.

@swift-ci please test

[pushkarnk]

@swift-ci please test

[pushkarnk]

@swift-ci please test

[naithar]

Since #713 also crashed the test with the same error, i checked this PR on my 16.04 local environment.

The issue seems to be in urlComponents.queryItems implementation. The exact lines that crashes is:

let entryName = oneEntry.object(forKey: "name"._cfObject) as! String
let entryValue = oneEntry.object(forKey: "value"._cfObject) as? String

After I changed this lines to:

let swiftEntry = oneEntry._swiftObject
let entryName = swiftEntry["name"] as! String
let entryValue = swiftEntry["value"] as? String

The issue seemed to be fixed and test performed without errors.

[saiHemak]

@ naithar : Thanks for debugging ..I was still in process of recreating it as I don't have Ubuntu 16.0.4 ..

[pushkarnk]

@swift-ci please test

[saiHemak]

@naithar : Thanks again ..It seems the build is passing with your suggested changes .Please let me know if you want to create PR or shall I go ahead with this PR including your suggested changes too ..

[naithar]

@saiHemak you are welcome :) Feel free to use my suggested changes in this PR, i won't mind.

[saiHemak]

@naithar : Thank you :)

[saiHemak]

@parkera : Please review ..

[parkera]

Thanks!

[parkera]

@swift-ci test and merge