Implementation of NSCoding for URLCredential #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLCredential NSCoding implementation URLCredential isEqual override status update status
|
Isn't |
parkera
reviewed
Nov 8, 2016
| return false | ||
| } | ||
|
|
||
| guard other !== self else { |
There was a problem hiding this comment.
A style note, but this feels more like a traditional if/else than a guard to me. I'd like to preserve the use of guard for preconditions and such.
|
@parkera updated |
|
@swift-ci please test and merge |
|
thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Keyed coding for URLCredentials. Non keyed is not supported in MacOS Foundation, so it's wasn't implemented.
Added test to cover
NSCodingchanges.Overriden
isEqualmethod to match MacOS Foundation.