Implement FileHandle.nullDevice #690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
Oct 18, 2016
|
|
||
|
|
||
| internal static var _nulldeviceFileHandle: FileHandle = { | ||
| return FileHandle(forUpdatingAtPath: "/dev/null")! |
There was a problem hiding this comment.
What's the portability story around /dev/null?
For what it's worth, the Darwin Foundation implementation here is a simple subclass of FileHandle that returns empty Data and values of 0 (except for file handle, which is -1).
There was a problem hiding this comment.
Good point. This has been tested and works on Ubuntu 15.10 and macOS. I have not been able to confirm that we have access to /dev/null on Android.
In any case a nullDevice subclass would be more efficient. I'll be away for a week but I can try implementing one when I get back.
|
@parkera this should be more like the Darwin implementation. |
|
Any news on this? |
|
Oh, sorry! This looks good to me. |
|
@swift-ci please test and merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if the unit test is needed. I may be testing OS functionality instead of Foundation.