Implementation of URLSessionTask.cancel() #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
naithar
reviewed
Nov 11, 2016
| s.delegateQueue.addOperation { | ||
| delegate.urlSession(s, task: self, didCompleteWithError: NSError(domain: NSURLErrorDomain, code: NSURLErrorCancelled, userInfo: nil)) | ||
| self.internalState = .taskCompleted | ||
| } |
There was a problem hiding this comment.
Wouldn't a call of completeTask(withError:) cover all situations when there is a need to perform a task completion? Or .cancel() should only call URLSession:task:didCompleteWithError: on delegate and not call any other callbacks?
pushkarnk
force-pushed
the
task-cancel
branch
from
5d5036e to
164be73
Compare
|
@swift-ci please test |
|
@naithar Thanks for the suggestion. Can you please review? |
|
Looks good to me. :) |
|
@parkera Can you please review? Thanks. |
|
Looks reasonable to me. |
|
Thanks. |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.