Skip to content

Fix Any? -> Any build warnings #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2016
Merged

Fix Any? -> Any build warnings #658

merged 1 commit into from
Oct 11, 2016

Conversation

e78l
Copy link
Contributor

@e78l e78l commented Sep 27, 2016 •
edited
Loading

Addressing build-time warnings of possibly nil values being used as Any SR-2737
Some whitespace fixes too

@e78l
Copy link
Contributor Author

e78l commented Sep 27, 2016

Realized I should include changes to NSHTTPCookie too; I had to change the time format to 'z' in my environment (Amazon Linux, ICU 57.1).
"O" doesn't work to parse "GMT" some reason...
The problem was caught by existing test. 'z' works OK and on my Mac too.
Heads up to @dbrajkovic and @pushkarnk in case something breaks but http://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table says 'O' is a fallback for 'z', so I don't expect any problems.

@parkera
Copy link
Contributor

parkera commented Sep 27, 2016

We had at least one situation with Any/Any? where it would warn either on Darwin or on Linux. @phausler should double check that.

Also, I would prefer we split up the HTTPCookie format changes into a separate PR.

@e78l
Fix Any? -> Any build warnings
02a490e 
New TZ test, HTTPCookie test revision
Fixes whitespace around changes
@e78l
Copy link
Contributor Author

e78l commented Sep 27, 2016

Updated - split off the HTTPCookie format change; HTTPCookie changes to silence warnings about optional values in [String:Any] remain

@e78l
Copy link
Contributor Author

e78l commented Oct 11, 2016

@phausler @parkera Chance for a review? I think this still applies though there've been more warnings introduced since (re: optional string interpolation).

@phausler
Copy link
Contributor

@swift-ci Please test and merge

@swift-ci swift-ci merged commit 5ab4679 into swiftlang:master Oct 11, 2016
@e78l e78l deleted the no-nil-any-warn branch October 12, 2016 01:00
@swift-ci swift-ci mentioned this pull request Oct 12, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@phausler phausler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e78l @parkera @phausler @swift-ci