Change RegularExpression back to NSRegularExpression

[pushkarnk]

No description provided.

[phausler]

@swift-ci please test and merge

[pushkarnk]

@phausler : Thanks for running the ci test. The URLSession data task test timed out here :-( Can you please trigger the test again?

[parkera]

@swift-ci please test and merge

[colemancda]

@parkera Any explanation why this was changed? I don't see any JIRA ticket or Swift evolution discussed related to this. Now we have to include a bunch of typealias for Swift 3.0 backwards compatibility. e.g orlandos-nl/BSON@9f3dfc8

[ikesyo]

@colemancda See https://github.com/apple/swift-evolution/blob/master/proposals/0086-drop-foundation-ns.md#proposed-solution.

If the class is planned to have a value-type equivalent in the near future, then keep the NS prefix. Examples: NSAttributedString, NSRegularExpression, NSPredicate.

The class was named as RegularExpression mistakenly at swift-corelibs-foundation (Linux) in Swift 3.0. So I think this is a bug fix.

You should consistently use NSRegularExpression:

#if os(Linux)
#if swift(>=3.1)
#else
public typealias NSRegularExpression = RegularExpression
#endif
#endif

[parkera]

Yah, the darwin version is NSRegularExpression as of Swift 3.0 and our charter here is to match that.