Fix for [SR-2486] Crash in NSDictionary.description with NSSet inside #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saiHemak
changed the title
|
@swift-ci Please test and merge |
xwu
reviewed
Sep 16, 2016
| failedConversion = true | ||
| stop.pointee = true | ||
| // here obj must be a swift type | ||
| if let nsObject = _SwiftValue.store(obj) as? Element { |
There was a problem hiding this comment.
Nit: can you make this an "else if" to avoid nested "if"?
There was a problem hiding this comment.
Edit--never mind, since it's being merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.