[SR-2617] POST requests should have Content-Type : application/x-www-form-urlencoded by default #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case provided in SR-2617 has highlighted multiple differences between Darwin and Linux, the second of which is that POST requests are automatically set to have a header value of
Content-Type : application/x-www-form-urlencodedon Darwin, but don't on Linux.The behaviour on Darwin is that:
URLRequest.allHTTPHeaderFieldsreq.setValue(value, forHTTPHeaderField: "Content-Type" )This PR mimics that behaviour by setting the header as we pass it to the underlying libcurl implementation, if and only if Content-Type isn't already set.