[NSGeometry] Use CGFloat.NativeType instead of hardcoded Double #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
nsgeometry-cgfloatnative
branch
from
9843a41 to
48cdf9e
Compare
|
@swift-ci please test |
|
We are having a related discussion about this in #622. Should some of the changes to CGFloat there be in this PR instead? |
|
Also #628 |
|
IMO, this PR has standalone value as it fixes issues on 32-bit platforms independent of the Android-related issues. The remaining CGFloat issues may have to do with build configuration tweaking specific to Android. |
|
This version compiles fine for Android. I’ll close my PR and revert CGFloat.swift and merge this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CGFloat.NativeTypeisFloaton 32bit platforms.