Implement missing functions in Date #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two NSUnimplemented functions in Date relate to a class property `timeIntervalSinceReferenceDate` which matches an instance property of the same name, and methods relating to the unkeyed coder. Implement the `timeIntervalSinceReferenceDate` by instantiating a new instance and delegating to the instance property, and change the unkeyed coder implementations to a fatalError indicating that they are unsupported.
Rather than having encode/decode functions with NSUnimplemented, ensure that they have a fatalError to prevent their use intentionally. Change existing code from using `if` to using `guard` to make the patterns more swifty.
|
@swift-ci please test |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two NSUnimplemented functions in Date relate to a class property
timeIntervalSinceReferenceDatewhich matches an instance propertyof the same name, and methods relating to the unkeyed coder.
Implement the
timeIntervalSinceReferenceDateby instantiating anew instance and delegating to the instance property, and change
the unkeyed coder implementations to a fatalError indicating that
they are unsupported.