Changed coefficients of UnitAngle to more exact values #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provided values were not as exact as they could be. In fact the value for "revolutions" was completely wrong (2π instead of 360°).
| static let gradians = 0.9 | ||
| static let revolutions = 6.28319 | ||
| static let revolutions = 360.0 |
There was a problem hiding this comment.
2π rad = 360° so why do you think it was wrong?
There was a problem hiding this comment.
That's true but the base unit is degrees so the conversion factor has to be 360.
|
@swift-ci please test linux |
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provided values were not as exact as they could be. In fact the value for "revolutions" was completely wrong (2π instead of 360°).