Implementation for NSIndexSet.copy(with:) #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| //Test copy operation of NSIndexSet case which is immutable | ||
| let selfIndexSet:NSIndexSet = NSIndexSet(indexesIn:range) |
There was a problem hiding this comment.
Please add the missing whitespaces here
gabhaska
force-pushed
the
nsindexset-branch
branch
from
fd17b41 to
7fef09c
Compare
|
@pushkarnk Thank you for the review. Changes done as suggested. |
|
@swift-ci please test |
| let indexSet = NSIndexSet() | ||
| indexSet._ranges = self._ranges | ||
| indexSet._count = self._count | ||
| return indexSet |
There was a problem hiding this comment.
Why wouldn't NSMutableIndexSet just override this and do the right thing, instead of having the superclass know about its subclass?
gabhaska
force-pushed
the
nsindexset-branch
branch
from
7fef09c to
afd48b8
Compare
|
@parkera I agree with your suggestion. I have addressed the same. Please review |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.