Fixes test case TestNSFileManger.test_fileAttributes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check only for the existence of file owner's account (user) identifier instead of comparing its numeric value because - user identifier of `0` are assigned to the superuser in linux - negative value are valid account identifier. e.g. `nobody` is `-2` (See https://en.wikipedia.org/wiki/User_identifier) - There's an assumption made here that account identifier are numeric which is reasonable for most system but there's a slim chance that this might not be the case. Thanks to @lxcid
|
Thanks! :D |
|
The assumption would probably just mean that we would not run this test on platforms like windows if/when it is ported to there. |
phausler
added a commit
that referenced
this pull request
Dec 7, 2015
Fixes test case TestNSFileManger.test_fileAttributes
|
Current implementation of the API returns NSNumber value for the NSFileOwnerAccountID key. This unit test checks if we are getting an NSNumber value for this key. |
|
Thanks for fixing quick @bartekchlebek ! |
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check only for the existence of file owner's account (user) identifier instead of comparing its numeric value because
0are assigned to the superuser in linuxnobodyis-2(See https://en.wikipedia.org/wiki/User_identifier)Thanks to @lxcid