Skip to content

Remove URLQueryItem from swift-corelibs-foundation in favor of FoundationEssentials.URLQueryItem #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/Foundation/NSURLQueryItem.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//


@_exported import FoundationEssentials
// NSURLQueryItem encapsulates a single query name-value pair. The name and value strings of a query name-value pair are not percent encoded. For use with the NSURLComponents queryItems property.
open class NSURLQueryItem: NSObject, NSSecureCoding, NSCopying {

Expand Down Expand Up @@ -64,6 +64,6 @@ extension NSURLQueryItem: _StructTypeBridgeable {
public typealias _StructType = URLQueryItem

public func _bridgeToSwift() -> _StructType {
return _StructType._unconditionallyBridgeFromObjectiveC(self)
return _StructType(name: self.name, value: self.value)
}
}
63 changes: 6 additions & 57 deletions Sources/Foundation/URLQueryItem.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,63 +7,12 @@
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//


/// A single name-value pair, for use with `URLComponents`.
public struct URLQueryItem: ReferenceConvertible, Hashable, Equatable {
public typealias ReferenceType = NSURLQueryItem

fileprivate var _queryItem: NSURLQueryItem

public init(name: String, value: String?) {
_queryItem = NSURLQueryItem(name: name, value: value)
}

fileprivate init(reference: NSURLQueryItem) { _queryItem = reference.copy() as! NSURLQueryItem }
fileprivate var reference: NSURLQueryItem { return _queryItem }

public var name: String {
get { return _queryItem.name }
set { _queryItem = NSURLQueryItem(name: newValue, value: value) }
}

public var value: String? {
get { return _queryItem.value }
set { _queryItem = NSURLQueryItem(name: name, value: newValue) }
}

public func hash(into hasher: inout Hasher) {
hasher.combine(_queryItem)
}

public static func ==(lhs: URLQueryItem, rhs: URLQueryItem) -> Bool {
return lhs._queryItem.isEqual(rhs._queryItem)
}
}

extension URLQueryItem: CustomStringConvertible, CustomDebugStringConvertible, CustomReflectable {
public var description: String {
if let v = value {
return "\(name)=\(v)"
} else {
return name
}
}

public var debugDescription: String {
return self.description
}

public var customMirror: Mirror {
var c: [(label: String?, value: Any)] = []
c.append((label: "name", value: name))
c.append((label: "value", value: value as Any))
return Mirror(self, children: c, displayStyle: .struct)
}
}
// URLQueryItem is defined in FoundationEssentials
@_exported import FoundationEssentials

extension URLQueryItem: _NSBridgeable {
typealias NSType = NSURLQueryItem
internal var _nsObject: NSType { return _queryItem }
internal var _nsObject: NSType { return NSURLQueryItem(name: self.name, value: self.value) }
}

extension URLQueryItem: _ObjectiveCBridgeable {
Expand All @@ -75,7 +24,7 @@ extension URLQueryItem: _ObjectiveCBridgeable {

@_semantics("convertToObjectiveC")
public func _bridgeToObjectiveC() -> NSURLQueryItem {
return _queryItem
return NSURLQueryItem(name: self.name, value: self.value)
}

public static func _forceBridgeFromObjectiveC(_ x: NSURLQueryItem, result: inout URLQueryItem?) {
Expand All @@ -85,7 +34,7 @@ extension URLQueryItem: _ObjectiveCBridgeable {
}

public static func _conditionallyBridgeFromObjectiveC(_ x: NSURLQueryItem, result: inout URLQueryItem?) -> Bool {
result = URLQueryItem(reference: x)
result = URLQueryItem(name: x.name, value: x.value)
return true
}

Expand All @@ -98,5 +47,5 @@ extension URLQueryItem: _ObjectiveCBridgeable {

extension NSURLQueryItem: _SwiftBridgeable {
typealias SwiftType = URLQueryItem
internal var _swiftObject: SwiftType { return URLQueryItem(reference: self) }
internal var _swiftObject: SwiftType { return URLQueryItem(name: self.name, value: self.value) }
}