Add upcall for FoundationEssentials to initialize NSNumbers #4966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itingliu
approved these changes
May 29, 2024
| @@ -9,6 +9,7 @@ | |||
|
|
|||
|
|
|||
| @_implementationOnly import _CoreFoundation | |||
| @_spi(SwiftCorelibsFoundation) @_exported import FoundationEssentials | |||
There was a problem hiding this comment.
Is it @_exported so that _typeByName("Foundation._FoundationNSNumberInitializer") is visible to FoundationEssentials?
There was a problem hiding this comment.
The @_exported attribute is the attribute that re-exports all of the symbols from FoundationEssentials. All of our imports of FoundationEssentials and FoundationInternationalization are @_exported so that Foundation.URL == FoundationEssentials.URL because Foundation is re-exporting FoundationEssentials and everything within it, so it's not specific to this change it's just something we have to add to every import of those modules
iCharlesHu
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the changes in swiftlang/swift-foundation#641 to initialize NSNumbers in FoundationEssentials