Update the way we check for libcurl feature availability #4962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@al45tair this came up when I merged your latest changes from main into our package branch, so including you for review as well. |
parkera
commented
May 21, 2024
| /* The maximum number of simultaneous persistent connections per host */ | ||
| @available(*, deprecated, message: "This platform doles not support selecting the maximum number of simultaneous persistent connections per host. This property is ignored.") |
There was a problem hiding this comment.
We lose this part, but that's the consequence until swiftpm supports something like cmake does here.
parkera
commented
May 21, 2024
| @@ -34,6 +34,27 @@ | |||
| #include <winsock2.h> | |||
| #endif | |||
|
|
|||
| // 7.84.0 or later | |||
| #if LIBCURL_VERSION_MAJOR > 7 || (LIBCURL_VERSION_MAJOR == 7 && LIBCURL_VERSION_MINOR > 84) || (LIBCURL_VERSION_MAJOR == 7 && LIBCURL_VERSION_MINOR == 84 && LIBCURL_VERSION_PATCH >= 0) | |||
| #define NS_CURL_CURLINFO_CAINFO_SUPPORTED 1 | |||
There was a problem hiding this comment.
I inverted the sense from "missing" to "supported" because it was a lot easier to understand.
jmschonfeld
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can't rely on
cmaketo inspect the version of curl when we build as a package, switch to using a different approach for verifying availability of features that rely on certain versions of libcurl.