[Need feedback]: Implemented isEqualToDictionary #49
Conversation
|
👍 |
| return false | ||
| } | ||
|
|
||
| for (key, value) in _storage { |
There was a problem hiding this comment.
Is NSDictionary subclassable? Then iterating over _storage wouldn't use the data from the subclass.
There was a problem hiding this comment.
I think the solution here would be to use keyEnumerator()
There was a problem hiding this comment.
@gribozavr Just corrected this issue using @amorde suggestion.
|
It would be great if you included tests. |
Absolutely, I'll incorporate the tests now then do a git rebase. |
|
This does not handle the CF bridged dictionary case or subclasses; _storage is only available when it is a NSDictionary constructed from swift and not a custom subclass etc. |
|
Looks good to me; a great follow up for this would definitely be some unit tests. However since it looks pretty cut and dry merging it in. |
Implemented isEqualToDictionary
|
@phausler O, thanks 😊 |
[swift] Fix folding range for comment.url, comment.mark types
[pull] swiftwasm from master
Implemented isEqualToDictionary and would like some feedback.