[wasm] Remove too conservative guards around file operations #4893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
kateinoigakukun
force-pushed
the
pr-60e5fee97c1f1f8f2dedb269343dbb7d1c1cf9b8
branch
from
bafcc09 to
2524fd2
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Mar 1, 2024
kateinoigakukun
force-pushed
the
pr-60e5fee97c1f1f8f2dedb269343dbb7d1c1cf9b8
branch
from
2524fd2 to
b6da20b
Compare
|
@swift-ci test |
|
@swift-ci test windows |
Those guards were added to prevent the build from failing on WASI, but they are too conservative and the latest wasi-libc is now providing enough support for these operations.
kateinoigakukun
force-pushed
the
pr-60e5fee97c1f1f8f2dedb269343dbb7d1c1cf9b8
branch
from
b6da20b to
7a70a1b
Compare
|
@swift-ci test |
MaxDesiatov
reviewed
Mar 6, 2024
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those guards were added to prevent the build from failing on WASI, but they are too conservative and the latest wasi-libc is now providing enough support for these operations.