[wasm][build] Disable networking targets from CMake build #4867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
approved these changes
Feb 7, 2024
|
@swift-ci test |
compnerd
requested changes
Feb 19, 2024
kateinoigakukun
force-pushed
the
pr-0f36722d80d2aa315829917cb564ab2773d2a9a3
branch
from
f4f29a4 to
17b8520
Compare
|
@swift-ci test |
compnerd
approved these changes
Feb 22, 2024
| install(TARGETS | ||
| CFURLSessionInterface | ||
| DESTINATION | ||
| "${CMAKE_INSTALL_FULL_LIBDIR}/$<LOWER_CASE:${CMAKE_SYSTEM_NAME}>") |
There was a problem hiding this comment.
I'm concerned that this might negatively impact Windows. Can you please test Windows as well?
|
@swift-ci Please test Windows platform |
This is a follow-up to 5e7281b, which introduced `BUILD_NETWORKING` option but didn't update the CMake build to respect it. This patch renames the option to follow CMake conventions and updates the build to respect it.
kateinoigakukun
force-pushed
the
pr-0f36722d80d2aa315829917cb564ab2773d2a9a3
branch
from
17b8520 to
a63cfba
Compare
|
@swift-ci Please test Linux Platform |
|
@swift-ci Please test Windows Platform |
|
@swift-ci test |
|
@swift-ci test windows |
kateinoigakukun
deleted the
pr-0f36722d80d2aa315829917cb564ab2773d2a9a3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to 5e7281b