NSGeometry: add unit tests #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh I just noticed #35. Ha, I should have looked more closely. Sorry for the dupe. 😄 This could still be considered for the unit tests alone. (Or considered altogether since it is a smaller change.) |
|
I'm going to ask for #35 to be rebased, then we can incorporate your unit tests as a PR on top of that. |
jessesquires
changed the title
atrick
pushed a commit
to atrick/swift-corelibs-foundation
that referenced
this pull request
Jan 12, 2021
[swiftpm] Update to latest master
kateinoigakukun
pushed a commit
to kateinoigakukun/swift-corelibs-foundation
that referenced
this pull request
Oct 11, 2023
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the following:
NSMake*functions fromNSGeometryNSMakePointNSMakeSizeNSMakeRectI decided to make
CGFloatimplementComparablemostly to simplify testing. (SinceCGFloat(1.0).nativebecame very verbose and repetitive.) However, I noticed that a PR for conformingNSDatetoComparablewas declined because it was considered an API change. It's not clear if this is also considered an API change that necessitates following the Swift evolution process sinceCGFloatis more or less a a basic type? In any case, I'm happy to make any necessary changes.