Skip to content

Fix incompatible function pointer type #4699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix incompatible function pointer type #4699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CoreFoundation/Parsing.subproj/CFXMLInterface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,13 @@ _CFXMLDTDNodePtr _CFXMLParseDTDNode(const unsigned char* xmlString) {
xmlUnlinkNode(node);
} else if (dtd->notations) {
node = (xmlNodePtr)calloc(1, sizeof(_cfxmlNotation));
// libxml2 v2.9.8 fixed their function signatures, but before that
// `xmlHashScanner` was defined without the const on `xmlChar *`.
#if LIBXML_VERSION > 20907
xmlHashScan((xmlNotationTablePtr)dtd->notations, &_CFXMLNotationScanner, node);
#else
xmlHashScan((xmlNotationTablePtr)dtd->notations, (void (*)(void *, void *, xmlChar *))&_CFXMLNotationScanner, node);
#endif
}

return node;
Expand Down