[SR-1552] Fix memory leak in NSMutableData and NSData #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks about right. I need to double check some other interactions before merging this. |
|
Hi @phausler - any update? Also, could we get this fix into |
|
Resolving this leak is important to server side applications on Linux. |
|
@phausler can this be merged? |
|
From what I can tell we actually had a similar fix already applied to the internal versions of CF, unfortunately I was bogged down with other tasks so there was a bit of delay on getting this in - so it will have to hit in the next cut of prebuilt toolchains |
This was referenced Jul 11, 2016
This was referenced Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for bug https://bugs.swift.org/browse/SR-1552
Memory held by NSData._bytes never gets reclaimed as __kCFDontDeallocate is set on NSData always.