Skip to content

Guard clauses for NSRequiresConcreteImplementation #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 19, 2016

Conversation

kouky
Copy link
Contributor

@kouky kouky commented May 19, 2016

Use guard statements to exit early with NSRequiresConcreteImplementation(). This approach is more succinct, and has the added safety of guard requiring a transfer of program control.

@parkera
Copy link
Contributor

parkera commented May 19, 2016

@swift-ci please test

@kouky
Copy link
Contributor Author

kouky commented May 19, 2016

@parkera the CI failure is the same for PR #372

_swift_stdlib_unicode_strToLower' can not be used when making a shared object

I've been working off the swift-3.0-preview-1-branch as a base as master has build failures on OSX when running the latest swift toolchain for Xcode. Merging master into this PR branch might fix the issue.

Just before I do that, can you please run CI against current master? It would be helpful to have a green baseline.

@parkera
Copy link
Contributor

parkera commented May 20, 2016

Yah we're in a bad state with the CI right now. I think it's going to clear up soon.

@parkera
Copy link
Contributor

parkera commented May 28, 2016

@swift-ci please test

@kouky
Copy link
Contributor Author

kouky commented May 29, 2016

@parkera i've merged master into this branch, the base commit for this branch is too old. Can we please run CI against it again?

@parkera
Copy link
Contributor

parkera commented Jun 19, 2016

This should be good to go now

@parkera
Copy link
Contributor

parkera commented Jun 19, 2016

@swift-ci please test

@parkera parkera merged commit 3cde50a into swiftlang:master Jun 19, 2016
@kouky
Copy link
Contributor Author

kouky commented Jun 20, 2016

@parkera awesome, my first PR merged 🎉

@kouky kouky deleted the guard-clauses-for-req-conc-impl branch June 20, 2016 00:01
@parkera
Copy link
Contributor

parkera commented Jun 20, 2016

Congrats and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants